Daily PR Report — 2026-06-11

rocprofiler-systems · ROCm/rocm-systems · label: project: rocprofiler-compute

Executive Summary

Total PRs: 27
In Review: 8 non-draft PRs passing CI or awaiting review
CI Failures: 9 PRs with failing or partially failing CI
Missing Tests: 4 PRs with source changes but no test updates
Stale: 0 PRs with 3+ days of no activity (Note: rocm-systems#4008 and rocm-systems#1793 warrant attention at 90 and 211 days old respectively)

This is the first report — no overnight delta available.

Key Highlights

Oldest open PR is 211 days old: rocm-systems#1793 (Fix stale hyperlinks) is approved by 3 reviewers and has passing CI in its relevant checks, but CI is failing on unrelated hip-tests and rdc jobs — this may be mergeable with the right coordination and deserves a final determination soon.
Sprint integration PR is failing CI: rocm-systems#6341 (Q2 Sprint 3, May 25 – Jun 12) is failing both rocprofiler-compute test shards and is the base branch for several other PRs — fixing CI here is a prerequisite for the sprint closing on Jun 12.
Large native PC sampling feature in flight across multiple PRs: rocm-systems#6416, rocm-systems#6991, rocm-systems#7088, and rocm-systems#6895 form a multi-PR chain (all by @abchoudh-amd and @vedithal-amd) that should be reviewed in order to avoid merge conflicts.
Several "healthy" PRs are stacked on each other: The vedithal-amd PC sampling UX series (parts 2–6: PRs #6838, #6873, #6890, #6894, #6895) are all approved and passing — they are ready to merge in sequence as soon as the base lands.
Two PRs have active changes-requested blocks: rocm-systems#6941 and rocm-systems#6693 both have changes requested by @vedithal-amd and need author response before they can progress.

PR Breakdown

Needs Attention (9)

PRs with failing CI or changes requested.

PR	Title	Author	CI	Review Status	Failing Checks / Blocker	Last Updated	Age
rocm-systems#7045	update vL1D Cache Hit/Cache Hit Rate for mi3xx	@xuchen-amd	❌	Pending	Build Linux Packages failing	2026-06-10	0d
rocm-systems#6941	use explicit mentions of percent of peak	@xuchen-amd	✅	⚠️ Changes requested by @vedithal-amd	Author must address review feedback	2026-06-10	2d
rocm-systems#6939	Support roctxProfilerPause/Resume in tool	@adanalis-amd	❌	Unknown	rocprofiler-sdk test shard 1 failing	2026-06-08	2d
rocm-systems#6693	Roofline support for gfx1151	@cfallows-amd	⏳	⚠️ Changes requested by @vedithal-amd	gfx1151/gfx950 builds failing; review changes outstanding	2026-06-11	8d
rocm-systems#6642	Multiframework support in inject_roctx module	@ggottipa-amd	❌	Pending	rocprofiler-compute shard 2, rocprofiler-sdk shard 1, gfx1151/gfx950, pre-commit failing	2026-06-10	9d
rocm-systems#6416	Route PC sampling collection through the native tool backend	@abchoudh-amd	❌	Pending	rocprofiler-compute shard 2, gfx950, pre-commit failing	2026-06-11	16d
rocm-systems#6341	Q2 Sprint 3 May 25 – Jun 12	@vedithal-amd	❌	Pending	rocprofiler-compute shards 1 & 2 both failing	2026-06-10	21d
rocm-systems#4008	[rocprofv3] Output flag (-o) bug fix with multiple processes	@itrowbri	❌	⚠️ Changes requested by @MythreyaK	10 checks failing across rocprofiler-sdk, gfx950/1151, multiple distros; WIP label	2026-05-28	90d
rocm-systems#1793	[NFC] Fix stale hyperlinks in rocm-systems	@saiislam	❌	✅ Approved (marifamd, dayatsin-amd, vedithal-amd)	12 checks failing (hip-tests, rocrtst, rdc — likely unrelated to changes)	2026-06-10	211d

In Review (8)

Passing CI, approved or awaiting review.

PR	Title	Author	CI	Review Status	Last Updated	Age
rocm-systems#7072	Bump rocm-docs-core 1.33.1→1.35.0 (docs deps)	[@dependabot[bot]](https://github.com/apps/dependabot)	✅	✅ Approved (cfallows-amd)	2026-06-11	0d
rocm-systems#7054	improve experimental feature docs	@xuchen-amd	✅	Pending	2026-06-10	0d
rocm-systems#7048	improve metric equation readability	@xuchen-amd	✅	Pending	2026-06-10	0d
rocm-systems#6895	Clean up PC sampling documentation	@vedithal-amd	✅	✅ Approved (feizheng10)	2026-06-10	3d
rocm-systems#6894	Add method-aware --pc-sampling-interval default	@vedithal-amd	✅	✅ Approved (feizheng10)	2026-06-10	3d
rocm-systems#6890	Unify PC sampling analysis for db and cli	@vedithal-amd	✅	✅ Approved (feizheng10, abchoudh-amd)	2026-06-10	3d
rocm-systems#6873	Drop PC sampling CSV outputs; consume JSON only	@vedithal-amd	✅	✅ Approved (abchoudh-amd)	2026-06-10	5d
rocm-systems#6838	Fill PC sampling analysis test gaps	@vedithal-amd	✅	✅ Approved (xuchen-amd, feizheng10, abchoudh-amd, cfallows-amd)	2026-06-10	6d

In Progress (0)

No PRs currently in this category (CI actively running on non-draft, non-failing PRs).

Drafts (10)

PR	Title	Author	CI	Age
rocm-systems#7088	Source PC sampling ISA lines from native collector	@abchoudh-amd	⏳	0d
rocm-systems#6991	Add native PC sampling collection to the tool library	@abchoudh-amd	⏳	1d
rocm-systems#6901	Adding Triton backend to marker injection	@ggottipa-amd	✅	3d
rocm-systems#6790	[WIP] gfx1151: RDNA 3.5 arch improvement and bug fixes	@feizheng10	❌	7d
rocm-systems#6729	[bugfix] pty fix for child processes	@xuchen-amd	❌	8d
rocm-systems#6694	Add test framework refactor team discussion (preview)	@feizheng10	✅	8d
rocm-systems#6485	Make rocpd .db the default profile output and parse it at analyze time	@jamessiddeley-amd	✅	14d
rocm-systems#6345	Add hardcoded-secret pre-commit hook	@abchoudh-amd	❌	21d
rocm-systems#6293	RCCL: Enable RMA CE path	@amd-arozanov	✅	22d
rocm-systems#6189	Reorganize tests into unit and integration	@vedithal-amd	❌	25d

Risk Signals

CI Instability

PR	Title	Author	Failing Checks	Last Updated
rocm-systems#7045	update vL1D Cache Hit/Cache Hit Rate for mi3xx	@xuchen-amd	TheRock CI Summary, Build Linux Packages	2026-06-10
rocm-systems#6939	Support roctxProfilerPause/Resume in tool	@adanalis-amd	TheRock CI Summary, rocprofiler-sdk test shard 1	2026-06-08
rocm-systems#6693	Roofline support for gfx1151	@cfallows-amd	gfx1151, gfx950, build-ubuntu-jammy, build-rhel ×2	2026-06-11
rocm-systems#6642	Multiframework support in inject_roctx module	@ggottipa-amd	TheRock CI Summary, rocprofiler-compute shard 2, rocprofiler-sdk shard 1, gfx1151, gfx950, pre-commit	2026-06-10
rocm-systems#6416	Route PC sampling collection through native tool backend	@abchoudh-amd	TheRock CI Summary, rocprofiler-compute shard 2, gfx950, pre-commit	2026-06-11
rocm-systems#6341	Q2 Sprint 3 May 25 – Jun 12	@vedithal-amd	TheRock CI Summary, rocprofiler-compute shards 1 & 2	2026-06-10
rocm-systems#4008	[rocprofv3] Output flag (-o) bug fix	@itrowbri	10 checks (rocprofiler-sdk, rocprofiler-compute, gfx950/1151, multiple distro Core/Coverage)	2026-05-28
rocm-systems#1793	[NFC] Fix stale hyperlinks in rocm-systems	@saiislam	12 checks (hip-tests ×6, rocrtst, rdc — likely unrelated to content)	2026-06-10

9/27 PRs have CI failures.

Test Gap Summary

4 PRs have source changes without corresponding test updates.

PR	Title	Author	Source Files Changed	Recommended Test Level	Risk of No Tests	Suggested Action
rocm-systems#7054	improve experimental feature docs	@xuchen-amd	`rocprof_compute_base.py`	Unit	Low	Docs/feature-flag change; check if `test_profiler_base.py` covers the affected flag path
rocm-systems#6939	Support roctxProfilerPause/Resume in tool	@adanalis-amd	`rocprofiler_compute_tool.cpp`	Integration	High	New profiler control feature — add integration tests covering pause/resume lifecycle; consider extending `test_profile_general.py` or adding a new `test_roctx_pause_resume.py`
rocm-systems#6729	[bugfix] pty fix for child processes	@xuchen-amd	`utils_common.py`	Unit	Medium	Bug fix in process handling utility — should have a unit test covering pty behavior for child processes; extend `test_utils.py` or add `test_utils_common.py`
rocm-systems#6293	RCCL: Enable RMA CE path	@amd-arozanov	`therock_configure_ci.py`	System	Low	CI configuration change; verify via CI run behavior; manual inspection likely sufficient, but a CI smoke test for the CE path toggle would reduce risk

17 PRs include test updates. 4 PRs are missing tests.

Stale PRs

Stale (25+ days no activity)

PR	Title	Author	Last Updated	Age	Recommendation
rocm-systems#1793	[NFC] Fix stale hyperlinks in rocm-systems	@saiislam	2026-06-10	211d	Already approved by 3 reviewers; failing CI appears unrelated to the content changes — evaluate whether failing checks are blocking and consider merging or triaging the unrelated CI failures to close this out.
rocm-systems#4008	[rocprofv3] Output flag (-o) bug fix with multiple processes	@itrowbri	2026-05-28	90d	Has unaddressed changes-requested from @MythreyaK and widespread CI failures; author should address review feedback and fix CI, or the PR should be closed and the bug tracked separately.
rocm-systems#6189	Reorganize tests into unit and integration	@vedithal-amd	2026-06-05	25d	Draft with failing CI; this is a structural refactor that may conflict with other test-touching PRs — author should assess whether to continue or close in favor of a fresh approach.

Going Stale (3–24 days no activity)

PR	Title	Author	Last Updated	Age
rocm-systems#6485	Make rocpd .db the default profile output	@jamessiddeley-amd	2026-06-03	14d
rocm-systems#6345	Add hardcoded-secret pre-commit hook	@abchoudh-amd	2026-05-25	21d
rocm-systems#6293	RCCL: Enable RMA CE path	@amd-arozanov	2026-06-10	22d

LLM Observations

The PC sampling native backend is a major coordinated effort spanning at least 6 PRs. The chain runs: #6991 (native tool library, draft) → #6416 (Python routing, failing CI) → #7088 (ISA lines from native collector, draft). Separately, #6838 → #6873 → #6890 → #6894 → #6895 form a fully approved UX improvement chain that is ready to merge in sequence — landing the base PR (#6838) should unblock the rest quickly.

rocm-systems#6642 (Multiframework inject_roctx) and rocm-systems#6901 (Triton backend) are directly related — #6901 targets #6642's branch. The failing CI on #6642 (pre-commit, multiple test shards) is a blocker for its downstream Triton draft. Fixing #6642's pre-commit and test failures should be prioritized.

The gfx1151 architecture is touched by at least 3 PRs simultaneously: #6693 (roofline support), #6790 (RDNA 3.5 arch fixes, draft), and #6642 (inject_roctx, which fails gfx1151 CI). These PRs likely touch overlapping files (soc_gfx1151.py, benchmark and spec files) and should be reviewed for conflicts before merging.

Sprint deadline pressure on #6341: The Q2 Sprint 3 integration PR (targeting Jun 12) is failing both rocprofiler-compute test shards and serves as the target branch for other feature PRs. With the sprint closing tomorrow, CI must be fixed urgently or the sprint branch will accumulate further debt.

Test coverage is generally strong for this project: 17 out of 27 PRs include test updates, and several PRs have impressively high test file counts (e.g., #6642 with 52 test files, #4008 with 97). The 4 PRs missing tests are relatively contained (1 source file each in 3 cases), with the notable exception of #6939 which adds a new profiler control feature with no test coverage.

Appendix

Raw Stats

Metric	Count
Total open PRs	27
Needs attention (failing CI / changes requested)	9
Healthy / In review	8
In progress (CI running)	0
Stale (3+ days no activity)	0
Drafts	10
WIP not draft	0
PRs with test updates	17
PRs missing tests (source changes, no tests)	4

Quick Links

Auto-generated: 2026-06-11